feat(docker): separation from autoware-universe stage to autoware-universe-sensing-perception stage
#5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
This reverts commit 789ee21.
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
changed the title
autoware-universe stage to autoware-universe-sensing-perception stageautoware-universe stage to autoware-universe-sensing-perception stage
oguzkaganozt
approved these changes
Sep 4, 2024
|
I know. That is why I proposed the base image to split the Dockerfiles. However you said this is also complex... https://github.com/orgs/autowarefoundation/discussions/5110#discussioncomment-10468337
|
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Sep 5, 2024
…universe-sensing-perception` stage (autowarefoundation#5164) * split depend stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add s/p stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * revert rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * Revert "revert rename" This reverts commit 789ee21. * simplify rosdep-depend Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
added a commit
that referenced
this pull request
Sep 5, 2024
…universe-sensing-perception` stage (#5164) * split depend stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add s/p stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * revert rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * Revert "revert rename" This reverts commit 789ee21. * simplify rosdep-depend Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
4 tasks
3 tasks
youtalk
added a commit
that referenced
this pull request
Sep 6, 2024
* rename stages Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update docker-bake Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update actions Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix target Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix inherits Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat(docker): separation from `autoware-universe` stage to `autoware-universe-sensing-perception` stage (#5164) * split depend stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add s/p stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * revert rename Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * Revert "revert rename" This reverts commit 789ee21. * simplify rosdep-depend Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix rebase Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * rename stages Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix bake Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix dockerfile Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix merge Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add universe-sensing-perception stage Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update config Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved #5079
This PR separates from the
autoware-universestage to theautoware-universe-sensing-perceptionstage, which builds only thesensingandperceptioncomponents.Subsequent PRs will similarly add stages divided by components.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.